Check for a valid blade extension when handling blade files #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blade files without valid exceptions in will cause an exception to be thrown during building. This is particularly noticeable with editor swap files (eg. vim has
.foo.blade.php.swp
) preventing the site from building. (Also reported in #274)This PR makes
BladeHandler::shouldHandle
check that the file has a valid extra blade extension (as defined inextraBladeExtensions
, or a standardblade.php
extension. If not, it will be rendered by the default handler.I'm not sure if this is the best approach, as it would silently let unlisted blade extensions pass through without the user being aware of it, but seems better than breaking the build entirely.
Would it possibly be better if we display a warning to the user notifying them of an invalid blade extension instead?