Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose writer deadline as part of the ResponseWriter interface #39

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

tigerwill90
Copy link
Owner

@tigerwill90 tigerwill90 commented Oct 8, 2024

This is small PR that expose SetReadDeadline and SetWriteDeadline as part of the fox.ResponseWriter interface.

This method are intended to control the server WriteTimeout and ReadTimeout on a per handler basis.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (9172015) to head (32df433).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   88.55%   89.22%   +0.66%     
==========================================
  Files          16       16              
  Lines        2080     2088       +8     
==========================================
+ Hits         1842     1863      +21     
+ Misses        182      171      -11     
+ Partials       56       54       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigerwill90 tigerwill90 marked this pull request as ready for review October 8, 2024 19:55
@tigerwill90 tigerwill90 changed the title Expose Writer Deadline Expose writer deadline as part of the ResponseWriter interface Oct 8, 2024
Copy link
Collaborator

@pawndev pawndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool feature !

@tigerwill90 tigerwill90 merged commit 07edc7e into master Oct 8, 2024
8 checks passed
@tigerwill90 tigerwill90 deleted the feat/expose-writer-deadline branch October 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants