Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Point and polygon theme elements #6249

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Dec 17, 2024

This PR aims to fix #6248.

It does the following:

  • New element_point() and element_polygon() elements.
  • New theme(point, polygon) arguments.
  • Gave sensible defaults for these theme settings.

It does not do the following:

  • Use these new elements in any meaningful way

@Yunuuuu
Copy link
Contributor

Yunuuuu commented Dec 18, 2024

I also require the element_polygon feature and have implemented it in my ggalign package to allows user to define links between two plots, as illustrated in the following figure (the blue and red polygons between the plots). I believe it would be more user-friendly if we could expose the alpha argument in element_polygon (and potentially in element_rect() as well).

@teunbrand
Copy link
Collaborator Author

Good to know I'm not the only one with this need :) I think exposing elements to alpha is a related but separate discussion that merits its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: elements for other graphical primitives
2 participants