Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for difftime #1532

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix for difftime #1532

merged 3 commits into from
Sep 9, 2024

Conversation

edward-burn
Copy link
Contributor

closes #1525

simonpcouch
simonpcouch approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can confirm that the DBMS' that received this change needed it and Spark was indeed correct. Just a NEWS edit, otherwise this PR is in a good spot.

NEWS.md Outdated Show resolved Hide resolved
@edward-burn @simonpcouch
Update NEWS.md
f1cf0df 
Co-authored-by: Simon P. Couch <[email protected]>
@simonpcouch simonpcouch merged commit 1ff6363 into tidyverse:main Sep 9, 2024
13 checks passed
@edward-burn edward-burn deleted the difftime branch December 4, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation of difftime() is inverted on Snowflake, MSSQL, Redshift
2 participants
@edward-burn @simonpcouch