Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep filtered aggregates with subsequent select in semi_join #1475

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Keep filtered aggregates with subsequent select in semi_join #1475

merged 1 commit into from
Mar 15, 2024

Conversation

ejneer
Copy link
Contributor

@ejneer ejneer commented Mar 7, 2024 •
edited
Loading

Fixes #1474

@ejneer ejneer force-pushed the semi_join_inline_having branch from 31c7970 to 14a9220 Compare March 9, 2024 15:24
@ejneer ejneer force-pushed the semi_join_inline_having branch from 14a9220 to 26c9294 Compare March 9, 2024 15:34
@ejneer ejneer changed the title Identify select queries with having clauses as not simple Keep filtered aggregates with subsequent select in semi_join Mar 9, 2024
@ejneer ejneer marked this pull request as ready for review March 9, 2024 15:37
@fh-mthomson fh-mthomson mentioned this pull request Mar 15, 2024
Closed
@hadley hadley merged commit 5355f88 into tidyverse:main Mar 15, 2024
13 checks passed
@hadley
Copy link
Member

hadley commented Mar 15, 2024

This seems like a low risk change (since we're choosing not to do a simplification in one case) and I'm about to release, so I've merged it. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snowflake translation error: dropped filter with anti_join
2 participants
@ejneer @hadley