str_like case sensitivity

If ignore_case is true, an error is thrown for dbms without ILIKE. If ignore_case is false, LIKE is used consistently across dbms
tidyverse · Apr 4, 2024 · d22e8e9 · d22e8e9
1 parent f3baed5
commit d22e8e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/R/backend-.R b/R/backend-.R
@@ -282,9 +282,14 @@ base_scalar <- sql_translator(
   str_sub = sql_str_sub("SUBSTR"),
   str_like = function(string, pattern, ignore_case = TRUE) {
     if (isTRUE(ignore_case)) {
-      sql_expr(!!string %LIKE% !!pattern)
+      bullets <- c(
+        "Backend does not support case insensitve {.fn str_like}.",
+        i = "Set ignore_case = FALSE for case sensitive match.",
+        i = "Note, using `tolower()` to cast string and pattern to lower case would also achieve a case insenitive match."
+      )
+      abort(bullets)
     } else {
-      cli::cli_abort("Backend only supports case insensitve {.fn str_like}.")
+      sql_expr(!!string %LIKE% !!pattern)
     }
   },
 

diff --git a/tests/testthat/_snaps/backend-.md b/tests/testthat/_snaps/backend-.md
@@ -42,7 +42,7 @@
 # can translate case insensitive like
 
     Code
-      test_translate_sql(str_like(x, "abc", ignore_case = FALSE))
+      test_translate_sql(str_like(x, "abc", ignore_case = TRUE))
     Condition
       Error in `str_like()`:
       ! Backend only supports case insensitve `str_like()`.