Silicon/Marvell: fix SMBIOS type 7 structures #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit [1] updated the uses of SMBIOS type 4 and 7 structures for
Silicon/Marvell but forgot to actually use SMBIOS_CACHE_SIZE_2
structures (introduced in commit [2]).
Compiling this platform fails with error:
edk2-platforms/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c:231:3: error: unsigned conversion from ‘int’ to ‘unsigned char:1’ changes value from ‘48’ to ‘0’ [-Werror=overflow]
231 | 48, //48k installed
| ^~
This commit fixes this issue.
[1] tianocore@8390e51
[2] tianocore/edk2@dfac150
Signed-off-by: Julien Olivain <ju.o@free.fr>
ndhillonm
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit [1] updated the uses of SMBIOS type 4 and 7 structures for Silicon/Marvell but forgot to actually use SMBIOS_CACHE_SIZE_2 structures (introduced in commit [2]).
Compiling this platform fails with error:
This commit fixes this issue.
[1] 8390e51
[2] tianocore/edk2@dfac150