Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worker's name #3745

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

Fix worker's name #3745

wants to merge 3 commits into from
+6 −0

Conversation

samaradel
Copy link
Contributor

Description

Rename worker after successful deployment

Changes

  • Create another worker's name after the deployment ends.

Related Issues

Tested Scenarios

Deploy a worker on any orchestrator instance. Don't close the dialog; instead, switch to the deploy tab and deploy another worker.

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3685

@samaradel samaradel marked this pull request as ready for review December 18, 2024 13:06
amiraabouhadid
amiraabouhadid requested changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to deploy a second worker without closing dialog, got this error
image

@samaradel samaradel marked this pull request as draft December 25, 2024 12:16
@samaradel samaradel marked this pull request as ready for review December 25, 2024 12:34
@samaradel samaradel mentioned this pull request Dec 25, 2024
Open
1 task
@samaradel
Copy link
Contributor Author

@amiraabouhadid it works fine with me, please try again and ensure you have the latest code.

0oM4R
0oM4R reviewed Dec 29, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast.from.2024-12-29.21-21-14.webm

the branch is updated with the remote one, i treid every thing to make sure that I'm on the correct branch, i notice that the branch name is similar to the old one maybe this is the problem

@samaradel samaradel marked this pull request as draft December 30, 2024 16:22
@samaradel samaradel marked this pull request as ready for review December 30, 2024 16:37
@samaradel
Copy link
Contributor Author

@0oM4R @amiraabouhadid I got it now, you guys are trying it on Caprover and it is fixed on k8s only, now it is fixed on Caprover too.

@samaradel samaradel requested a review from 0oM4R December 30, 2024 16:38
0oM4R
0oM4R requested changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working with me it stuck on this
image

@samaradel samaradel marked this pull request as draft January 1, 2025 12:50
@samaradel samaradel marked this pull request as ready for review January 1, 2025 13:53
@samaradel samaradel requested a review from 0oM4R January 1, 2025 13:53
@samaradel
Copy link
Contributor Author

@0oM4R fixed now

@0oM4R
Copy link
Contributor

0oM4R commented Jan 1, 2025

@0oM4R fixed now

its not enough the selected node is the same, which may lead to a resource error.
i got this error, the name got changed but the selected node is not updated.
image

@samaradel samaradel marked this pull request as draft January 2, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samaradel @0oM4R @amiraabouhadid @maayarosama