Parse Multi Values Inputs With Quotation #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threeal
force-pushed
the
parse-multi-vals-inputs-with-quotation
branch
from
00b8b03 to
c01583e
Compare
Signed-off-by: Alfi Maulana <[email protected]>
threeal
force-pushed
the
parse-multi-vals-inputs-with-quotation
branch
from
c01583e to
a3faf40
Compare
Signed-off-by: Alfi Maulana <[email protected]>
Signed-off-by: Alfi Maulana <[email protected]>
threeal
changed the title
|
Hey @threeal, do you think it would be a good idea to add this new feature to one of the tests so that it is always automatically tested? |
|
@MartinSalinas98 It's already tested in unit tests, and i'm planning to minimize the integration tests in CI as it seems having unit tests should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for parsing quotations for inputs that support multiple values, allowing those inputs to include values containing whitespace as long as they are enclosed in quotation marks. It closes #519.