Merge pull request #321 from threadi/feature/optimizedUsageOnPosition…

…Deletion

optimized usage on position deletion via WP CLI

app/PersonioIntegration/PostTypes/PersonioPosition.php

@@ -761,7 +761,7 @@ public function delete( int $post_id ): void {
 		$user = wp_get_current_user();
 
 		// if no user could be found, check if we are running on WP CLI.
-		if ( empty( $user ) ) {
+		if ( is_null( $user ) ) {
 			$username = 'WP CLI';
 		} else {
 			$username = $user->display_name;
@@ -1786,9 +1786,16 @@ public function delete_positions(): void {
 		// get current user for logging.
 		$user = wp_get_current_user();
 
+		if( is_null( $user ) ) {
+			$username = 'WP CLI';
+		}
+		else {
+			$username = $user->display_name;
+		}
+
 		// log this event.
 		$logs = new Log();
-		$logs->add_log( sprintf( 'Positions has been deleted by %1$s.', esc_html( $user->display_name ) ), 'success', 'import' );
+		$logs->add_log( sprintf( 'Positions has been deleted by %1$s.', esc_html( $username ) ), 'success', 'import' );
 
 		/**
 		 * Run custom actions after deletion of all positions has been done.

changelog.md

@@ -14,6 +14,7 @@
 - plugin version number is now automatically generated in readme.txt during plugin release build
 - Cleaned up third party support from unused code
 - Moved changelog from readme.txt in GitHub-repository
+- Optimized documentation of deleted position via WP CLI
 - Extended help for debug mode
 - Colored the helper tab for better visibility