Handle similar gem names in updated_version_for #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bummr can get confused when updating a gem when there is another gem used by the project that is named similarly but with a prefix. E.g. when updating websockets, bummr can get confused by the presence of em-websockets and pick the version number of em-websockets for the commit message. This commit fixes that problem by anchoring the regex on the directory separator. Note that I'm not sure how this behaves on Windows. My hope is that `bundle list --paths` uses the directory separator as is specified in `File::SEPARATOR`, but this is untested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bummr can get confused when updating a gem when there is another gem used by the project that is named similarly but with a prefix. E.g. when updating websockets, bummr can get confused by the presence of em-websockets and pick the version number of em-websockets for the commit message.
This commit fixes that problem by anchoring the regex on the directory separator.
Note that I'm not sure how this behaves on Windows. My hope is that
bundle list --pathsuses the directory separator as is specified inFile::SEPARATOR, but this is untested.