Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui_utils.py line 978 to fix issue thonny#659 #2169

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

jharris1993
Copy link
Contributor

Issue #659 describes an issue where the horizontal scroll bar doesn't appear unless the user begins to traverse a long line that extends outside the viewport.

On May 31, 2020 @lurch submitted a fix:
#659 (comment)

This is that fix implemented.

Issue thonny#659 describes an issue where the horizontal scroll bar doesn't appear unless the user begins to traverse a long line that extends outside the viewport.

On May 31, 2020 lurch submitted a fix:
thonny#659 (comment)

This is that fix implemented.
Update ui_utils.py line 978 to fix issue thonny#659
@jharris1993
Copy link
Contributor Author

Note that with this fix in place, the horizontal scroll bar can "blink" if the long line is only partially visible.

IMHO, though possibly distracting to some people, I think it is much better than not having access to the scroll bar at all and that the "blinking" represents a separate issue.

@aivarannamaa aivarannamaa merged commit 9d027ca into thonny:master Feb 15, 2022
@aivarannamaa
Copy link
Member

Thank you for this push!

As I described in the issue, I was hoping to do a more proper fix, but never got there. In any case this fix is better than the current state.

The fix will be in the first beta of 4.0

@jharris1993
Copy link
Contributor Author

jharris1993 commented Feb 15, 2022

You are most welcome.

It puzzled me to no end why, though everyone was complaining about it, and there was even a fix documented, it "never got there" and there wasn't even a pull request!

I figured that, maybe everyone else was too busy, so I'd try.

When do you expect the beta to come out?

@aivarannamaa
Copy link
Member

When do you expect the beta to come out?

I'm hoping for the end of February

@jharris1993
Copy link
Contributor Author

Any chance you can send me a line so I can come and try it?

@aivarannamaa
Copy link
Member

@jharris1993, you could subscribe to the release notifications of this repo. Click on the "Watch" button on top of this page, select "Custom" and then check "Releases".

@jharris1993
Copy link
Contributor Author

jharris1993 commented Feb 17, 2022

That will include beta releases? Interesting!

Done. . . .

@aivarannamaa
Copy link
Member

aivarannamaa commented Feb 17, 2022

I always thought that this includes betas and https://github.community/t/feature-request-filter-pre-releases-from-notifications-watch-custom-releases/180052 seems to confirm my theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants