Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor chainId from number to string in contractSubscriptions #759

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Nov 5, 2024

PR-Codex overview

This PR focuses on changing the data type of the chainId field in the contract_subscriptions table from Int to String. It updates related code to ensure consistent handling of chainId as a string.

Detailed summary

  • Altered chainId column type in the contract_subscriptions table to TEXT.
  • Updated createContractSubscription.ts to convert chainId to a string.
  • Changed schema.prisma to reflect chainId as a String.
  • Modified contractSubscription.ts to parse chainId as an integer.
  • Adjusted getContractSubscriptions.ts to convert chainId to a string in queries.
  • Updated the return value in getContractSubscriptionsUniqueChainIds to parse chainId as an integer.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@d4mr d4mr requested a review from arcoraven November 5, 2024 09:28
@d4mr d4mr merged commit ba59e74 into main Nov 5, 2024
5 checks passed
@d4mr d4mr deleted the pb/cs-chainId-string branch November 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants