fix: Simplify Contract Subscriptions block range #744
Conversation
| @@ -69,10 +69,6 @@ export const env = createEnv({ | |||
| SDK_BATCH_TIME_LIMIT: z.coerce.number().default(0), | |||
| SDK_BATCH_SIZE_LIMIT: z.coerce.number().default(100), | |||
| ENABLE_KEYPAIR_AUTH: boolEnvSchema(false), | |||
| CONTRACT_SUBSCRIPTIONS_DELAY_SECONDS: z.coerce | |||
There was a problem hiding this comment.
Experimental + undocumented. Not useful.
| 1: 12, | ||
| 137: 2, | ||
| } as Record<number, number>; | ||
| export const getBlockTimeSeconds = async ( |
There was a problem hiding this comment.
Simplifies logic + moves to v5.
Previously this code was summing the timestamps for 100 blocks. Now it just takes the diff between the n and n-100 block, which should be equivalent.
|
|
||
| // Compute block offset based on delay. | ||
| // Example: 10s delay with a 3s block time = 4 blocks offset | ||
| const toBlockOffset = env.CONTRACT_SUBSCRIPTIONS_DELAY_SECONDS |
There was a problem hiding this comment.
Removing this. Unused.
| const blocksIn5Seconds = Math.round((1 / blockTimeSeconds) * 5); | ||
| const maxBlocksToIndex = Math.max( | ||
| config.maxBlocksToIndex, | ||
| blocksIn5Seconds * 4, | ||
| ); |
There was a problem hiding this comment.
This was more complicated than it's worth. The goal was to find a good range of blocks to query. Honestly if we're realtime we're usually querying 5 seconds worth of blocks (2-20 depending on the block time). Hard coding this to 500: a value greater than this but less than most eth_getLogs limits should suffice.
|
|
||
| const chainIndexerTask = async () => { |
There was a problem hiding this comment.
Changes:
- This function no longer returns a function, it just executes the logic.
- Remove try/catch, already caught above.
- Move to v5 SDK
PR-Codex overview
This PR focuses on improving the handling of transaction receipts and event logs within a blockchain indexing worker. It includes enhancements to logging, error handling, and the estimation of block times, while also refactoring some code for better clarity and efficiency.
Detailed summary
processTransactionReceiptsWorker.ts.parseInttoNumber.parseIntinmanageChainIndexers.ts.getChainIndexer.ts.getBlockTimeSecondsingetBlockTime.test.ts.CONTRACT_SUBSCRIPTIONS_DELAY_SECONDSfrom environment variables inenv.ts.chainIndexerListener.ts.chainIndexer.ts.getBlockTime.ts.chainIndexer.ts.