chore: Update deps with reported security vulnerabilities (first pass) #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Oct 29, 2024
| "@bull-board/fastify": "^5.21.1", | ||
| "@cloud-cryptographic-wallet/cloud-kms-signer": "^0.1.2", | ||
| "@cloud-cryptographic-wallet/signer": "^0.0.5", | ||
| "@fastify/basic-auth": "^5.1.1", | ||
| "@fastify/cookie": "^8.3.0", | ||
| "@fastify/cookie": "^9.2.0", |
There was a problem hiding this comment.
This is the only major version bump and impacts thirdweb-dev/auth:
=> Found "@thirdweb-dev/auth#@fastify/[email protected]"
I tested dashboard auth and access token auth to confirm there were no breaking changes.
| "cookie": "^0.5.0", | ||
| "cookie-parser": "^1.4.6", | ||
| "cookie": "^0.7.0", | ||
| "cookie-parser": "^1.4.7", |
There was a problem hiding this comment.
i would recommend using strict versions here rather than ^ ones. you never know what patch update is gonna get sneaked in there otherwise
There was a problem hiding this comment.
Hmm I think this is a mixed opinion, will ping the channel for more thoughts.
Updating minor versions gets us security/performance improvements, but you're right it can introduce unintentional breaking changes.
d4mr
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates the dependencies in the
package.jsonandyarn.lockfiles, including major version upgrades for various packages, which may enhance functionality, security, and performance.Detailed summary
@aws-sdk/client-kmsfrom^3.398.0to^3.679.0@bull-board/fastifyfrom^5.21.1to^5.23.0@fastify/cookiefrom^8.3.0to^9.2.0body-parserfrom^1.20.2to^1.20.3dd-tracefrom^5.19.0to^5.23.0fastifyfrom^4.15.0to^4.28.1@types/nodeand other@smithydependencies to newer versions