Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tsconfig.json compilerOptions #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vellengs
Copy link

support for project's tsconfig.json

support for project's tsconfig.json
@ngraef
Copy link
Collaborator

ngraef commented Nov 10, 2017

Good start. I think this needs a couple things before a merge though:

  • (Optional) Add a configuration option tsConfigFile to override the default location of the tsconfig.json file
  • Handle the case where require throws an error because tsconfig.json doesn't exists where you're looking for it and fallback to using empty config
  • Handle the case where tsconfig.compilerOptions is undefined and fallback to using empty config
  • Fix linting error ERROR: src/metadata/metadataGenerator.ts[14, 68]: trailing whitespace

@ngraef ngraef changed the title Update metadataGenerator.ts Use tsconfig.json compilerOptions Nov 10, 2017
@vellengs
Copy link
Author

@ngraef
It's good strict for that;
I have a suggestion.
why not move to configurable swagger.config then user make the decision.

@tnrich
Copy link
Collaborator

tnrich commented Feb 21, 2020

@vellengs any movement on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants