Dues estimator to reduce currencylayer usage #10767
Open
+72
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljames-dj
force-pushed
the
dues-estimator
branch
from
e28d3c5 to
0d4b87b
Compare
kr-matthews
reviewed
Feb 4, 2025
Comment on lines
+14
to
+17
| const currencyInfo = useMemo( | ||
| () => (currenciesData.byIso[currencyCode] || currenciesData.byIso.USD), | ||
| [currencyCode], | ||
| ); |
There was a problem hiding this comment.
I don't think there's any need to memoize this.
|
|
||
| const { | ||
| data, loading, error, | ||
| } = useLoadedData(calculateDuesUrl(countryId, currencyCode, baseEntryFee)); |
There was a problem hiding this comment.
Can we use useQuery here? useLoadedData has some issues and I think the plan is to replace it at some point anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For getting currency details, we moved to currencylayer API which is paid. Currently, the dues is shown on competition edit page, but it may not be noticed every time by the user. So it has been replaced with a button now as shown below:
When the user clicks the button, they will be able to see the dues estimate. This view not only shows the dues estimate, but also allows user to change the competitor count temporarily and see what is the dues for that competitor count:
The future plan of this component will be to explain the dues calculation method used in this component, so that delegate can easily understand it from here, and hence reduce queries to WFC on 'why is the dues xyz for n competitors'.