Filter out invalid items in IdWcaSearch #10733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
fixup/id-search-invalid-items
branch
from
22cc89c to
34d61ea
Compare
|
See #10730 for context, and to find out what "inspired" me to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent any React pages from crashing that use
IdWcaSearchwith values that cannot be found (because either they really don't exist like competitions with IDFoobarOpenLOL1979Reallyor because we pretend like they don't exist, for example unannounced competitions)An alternative solution would be to add an extra "Competition Admin" model to the search, which maps to an endpoint that always reveals data even for unannounced competitions, We would have to be careful about using that one, though