Migrate Create newcomers entry page to react #10732
+112
−84
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import React from 'react'; | ||
| import { | ||
| Button, Form, Header, HeaderSubheader, | ||
| } from 'semantic-ui-react'; | ||
| import { IdWcaSearch } from '../../../SearchWidget/WcaSearch'; | ||
| import SEARCH_MODELS from '../../../SearchWidget/SearchModel'; | ||
| import { viewUrls } from '../../../../lib/requests/routes.js.erb'; | ||
| import useQueryParams from '../../../../lib/hooks/useQueryParams'; | ||
| import useInputState from '../../../../lib/hooks/useInputState'; | ||
|
|
||
| export default function CompetitionsInput() { | ||
| const [queryParams] = useQueryParams(); | ||
| const competitionIdsFromQuery = queryParams?.competition_ids?.split(','); | ||
| const [competitionIds, setCompetitionIds] = useInputState(competitionIdsFromQuery || []); | ||
|
|
||
| return ( | ||
| <Form> | ||
| <IdWcaSearch | ||
| model={SEARCH_MODELS.competition} | ||
| multiple | ||
| value={competitionIds} | ||
| onChange={setCompetitionIds} | ||
| label="Competition(s)" | ||
| /> | ||
| <Header as="h4"> | ||
| <HeaderSubheader> | ||
| Leave blank to check for all competitions | ||
| </HeaderSubheader> | ||
| </Header> | ||
| <Button | ||
| primary | ||
| size="big" | ||
| href={viewUrls.admin.completePersons(competitionIds.length > 0 ? competitionIds : null)} | ||
| > | ||
| Check newcomers | ||
| </Button> | ||
| </Form> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import React from 'react'; | ||
| import { Header, List, ListItem } from 'semantic-ui-react'; | ||
| import CompetitionsInput from './CompetitionsInput'; | ||
|
|
||
| export default function CreateNewcomersPage() { | ||
| return ( | ||
| <> | ||
| <Header>Create Newcomers</Header> | ||
| <Information /> | ||
| <CompetitionsInput /> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| function Information() { | ||
| return ( | ||
| <> | ||
| <p> | ||
| In this script, a "person" always means a triple of (id,name,countryId) and | ||
| "similar" always means just name similarity. A person is called | ||
| "finished" if it has a non-empty personId. A "semi-id" is the id | ||
| without the running number at the end. | ||
| </p> | ||
| <p> | ||
| For each unfinished person in the Results table, I show you the few most similar | ||
| persons. Then you make choices and click "update" at the bottom of the page | ||
| to show and execute your choices. You can: | ||
| </p> | ||
| <List bulleted> | ||
| <ListItem> | ||
| Choose the person as "new", optionally modifying name, country and | ||
| semi-id. This will add the person to the Persons table (with appropriately | ||
| extended id) and change its Results accordingly. If this person has both roman and | ||
| local names, the syntax for the names to be inserted correctly is | ||
| "romanName (localName)". | ||
| </ListItem> | ||
| <ListItem> | ||
| Choose another person. This will overwrite the person's (id,name,countryId) | ||
| triple in the Results table with those of the other person. | ||
| </ListItem> | ||
| <ListItem> | ||
| Skip it if you're not sure yet. | ||
| </ListItem> | ||
| </List> | ||
| </> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to wrap this in an array? Passing it as a string should be just fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it do accept single string as well I guess, but there are cases where multiple competitions are also needed to be given as input. So, to make the type of
competition_idsas a single type (array of string) instead of multiple type (array of string or single string), I thought of doing this way. Is it fine?