Don't display team/committee acronym in header #10692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the code that displays the team/committee `friendly_id`, which has additional meaning under-the-hood that was leading to incorrect display of acronyms. In particularly, Appeals Committee was being displayed as "WAPC" instead of the desired "WAC". This is not a complete fix, as `#wapc` is still used as the URL fragment when viewing the Appeals Committee page, but it does resolve the more visible instance of the wrong acronym. This commit also adjusts the langauge in the en locale file to use the defined acronym, and aligns with best technical writing practices when applicable (plus some other small improvements/changes to team responsibilities).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the code that displays the team/committee
friendly_id, which has additional meaning under-the-hood that was leading to incorrect display of acronyms. In particularly, Appeals Committee was being displayed as "WAPC" instead of the desired "WAC".This is not a complete fix, as
#wapcis still used as the URL fragment when viewing the Appeals Committee page, but it does resolve the more visible instance of the wrong acronym.This commit also adjusts the langauge in the en locale file to use the defined acronym, and aligns with best technical writing practices when applicable (plus some other small improvements/changes to team responsibilities).