Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCA Live Integration Pre Work #2: Add liveResult and liveAttempt models #10685

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

FinnIckler
Copy link
Member

Also confirmed working using my test page.
wca live's result table additionally has

      t.integer :ranking
      t.integer :best, null: false
      t.integer :average, null: false
      t.string :single_record_tag, limit: 255
      t.string :average_record_tag, limit: 255
      t.boolean :advancing, default: false, null: false
      t.boolean :advancing_questionable, default: false, null: false

But I am not sure which one of these we should also use and which one we should just compute on the fly.

@FinnIckler
Copy link
Member Author

FinnIckler commented Feb 5, 2025

I've added the factories and some basic tests. There will be a ton more when validating cutoffs and time limits will be introduced in a future pr

app/jobs/add_live_result_job.rb Outdated Show resolved Hide resolved
app/jobs/add_live_result_job.rb Show resolved Hide resolved
app/models/live_result.rb Outdated Show resolved Hide resolved
app/models/live_result.rb Outdated Show resolved Hide resolved
app/models/live_result.rb Outdated Show resolved Hide resolved
db/migrate/20250124154917_create_live_result_tables.rb Outdated Show resolved Hide resolved
db/migrate/20250124154917_create_live_result_tables.rb Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants