Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject user registration edits if comp has started #10605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reject user registration edits if comp has started #10605

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bf1409
return false if comp has started
dunkOnIT Jan 12, 2025
fa56b27
Update app/models/competition.rb
dunkOnIT Jan 13, 2025
2696c08
changed function name and added tests
dunkOnIT Jan 18, 2025
58b3e51
rubocop
dunkOnIT Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/competition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,7 @@ def has_event_change_deadline_date?
# can registration edits be done right now
# must be allowed in general, and if the deadline field exists, is it a date and in the future
def registration_edits_allowed?
self.allow_registration_edits &&
!started? && self.allow_registration_edits &&
(!has_event_change_deadline_date? || !event_change_deadline_date.present? || event_change_deadline_date > DateTime.now)
end

Expand Down
Loading