userspace: add support to use DAIs from user threads #10421

kv2019i · 2025-12-09T12:21:08Z

Add support to use DAIs from a user-thread. This includes modification of dai-zephyr.c to use SOF DMA wrapper that provides syscall interface for the DMA interface.

For the actual DAI interface, user-space support is added directly to Zephyr (see zephyrproject-rtos/zephyr#99811 ).

This PR doesn't yet affect any current default configuration. To allow to test the new user-space flows, a separate test case is added to test DMA+DAI (mimicking what dai-zephyr.c does) in a standalone test case.

Note: there is no hard dependency on the Zephyr-side PRs. The test case will not pass until all dependencies are included, but this PR can be merged before this.

Copilot

Pull request overview

This PR adds support for using DAI (Digital Audio Interface) functionality from user-space threads by introducing a SOF DMA wrapper with syscall interfaces. The implementation modifies dai-zephyr.c to use the new wrapper functions instead of direct Zephyr DMA API calls, and adds a standalone test case to verify the user-space DMA+DAI flows.

Key changes:

Migration of DMA API calls to SOF wrapper functions (sof_dma_*) in dai-zephyr.c
Addition of suspend/resume syscalls to the SOF DMA interface
New user-space test case for Intel SSP DAI functionality

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`zephyr/test/userspace/test_intel_ssp_dai.c`	New comprehensive test case demonstrating user-space DMA and DAI operations with SSP device
`zephyr/test/CMakeLists.txt`	Updated build configuration to include the new SSP DAI test case
`zephyr/syscall/sof_dma.c`	Added syscall verification functions for DMA suspend/resume operations
`zephyr/include/sof/lib/sof_dma.h`	Added suspend/resume function declarations and implementations to the SOF DMA wrapper
`src/include/ipc4/gateway.h`	Removed unnecessary struct member names in union definitions
`src/audio/dai-zephyr.c`	Migrated all DMA API calls from direct Zephyr calls to SOF wrapper functions

Comments suppressed due to low confidence (1)

zephyr/test/userspace/test_intel_ssp_dai.c:1

Incorrect channel index used in cleanup. This should be channel_in instead of channel_out, as the preceding line releases channel_out.

// SPDX-License-Identifier: BSD-3-Clause

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zephyr/test/userspace/test_intel_ssp_dai.c

softwarecki · 2025-12-09T14:41:57Z

zephyr/test/CMakeLists.txt


 if (CONFIG_SOF_BOOT_TEST_STANDALONE)
-       if (CONFIG_DT_HAS_INTEL_ADSP_HDA_HOST_IN_ENABLED AND CONFIG_SOF_USERSPACE_INTERFACE_DMA)
-              zephyr_library_sources(userspace/test_intel_hda_dma.c)


Is it safe to run this test when userspace is active without CONFIG_SOF_USERSPACE_INTERFACE_DMA?
Was the change from test test_intel_hda_dma.c to test test_intel_ssp_dai.c intentional?
Shouldn't both tests be executed in this scenario?

CONFIG_SOF_USERSPACE_INTERFACE_DMA depends on CONFIG_USERSPACE, so this is safe, but indeed the logic within the if case is not correct. This was messed up when I did the rebase, let me rework this in V2. Thanks!

softwarecki · 2025-12-09T15:01:22Z

While adding more the syscalls for dma, could we also wrap the following lines in if (CONFIG_SOF_USERSPACE_INTERFACE_DMA), similar to what is done in zephyrproject-rtos/zephyr#99811 ?

sof/zephyr/CMakeLists.txt

Lines 493 to 497 in e00764e

    
           zephyr_library_sources_ifdef(CONFIG_USERSPACE 
        
           	syscall/sof_dma.c 
        
           ) 
        
           zephyr_syscall_header(include/sof/lib/sof_dma.h)

lyakh · 2025-12-10T10:44:57Z

zephyr/test/userspace/test_intel_ssp_dai.c

+	blob30.b.size =			sizeof(blob30);
+	/* I2S config */
+	blob30.b.i2s_ssp_config.ssc0 =		0x81d0077f;
+	blob30.b.i2s_ssp_config.ssc1 =		0xd0400004;


should we have some comments here? And indentation is off

@lyakh are you saying raw hex values are not our preferred language? Are we mice or are we men? :) Let me add a comment. I was not planning to document these in detail (as we don't have the bitfield definitions in FW codebase and adding them just for a test case does not seem sensible -- we have a completely open generator in upstream alsa-utils after all), but I thought having the individual registers separated (versus just a big "uint8_t blob30[]") might come handy if you want to debug the SSP driver. This test case is a potentially nice way to exercise the driver on hardware. But alas, better comments are in order, let me add in V2.

UPDATE: and indentation is ok, it's github web view messing it up

@kv2019i feel free to write the comment in hex, 0x6e,0x6f,0x20,0x70,0x72,0x6f,0x62,0x6c,0x65,0x6d,0x20,0x77,0x69,0x74,0x68,0x20,0x6d,0x65 ;-)
yep, understand, not proposing a full bit-by-bit documentation, just a short comment about where this comes from would be nice

kv2019i · 2025-12-10T19:51:42Z

V2:

addressed comments from @softwarecki and @lyakh
fixed test build&run -- retain ability to build all tests, and to run them all (and once per test)
add a few minor fixes to the HDA DMA test (needed to cleanly run this before the SSP DAI test and thus in this PR)
fixed a bug in SSP DAI test
updated the test README to match the new code

kv2019i · 2025-12-12T15:59:09Z

@lrudyX It seems the 06_07_TestBasicHdaLinkRandomDma is failing here. I don't think this is related, but given this PR does change dai-zephyr, probably better to do another test-run. Let me rebase the PR to latest SOF main -- no change to code, just a clean rebase, and let's see if the issue repeats.

gateway.h defines "union flags" and "struct bits" to global namespace, which is not good in a public interface header file. There's no functional need to tag these struct definitions, so make the definitions anonymous. Signed-off-by: Kai Vehmanen <[email protected]>

Extend coverage of the Zephyr DAI interface to include dma_suspend() and dma_resume() calls exposed as syscalls. This allows e.g. to run the DAI module in a user thread. Signed-off-by: Kai Vehmanen <[email protected]>

The sof_dma.h syscalls are emitted to build whenever CONFIG_USERSPACE is set. Limit this so that the syscalls are emitted only if CONFIG_SOF_USERSPACE_INTERFACE_DMA is set. Signed-off-by: Kai Vehmanen <[email protected]>

Use the sof/lib/dma.h wrapper interface to access DMA devices. This allows to run this code also from user-space. The commit has no impact to builds where userspace is not used. Also this will not impact builds where user-space is enabled for some functionality, but the dai/copier module is not run in user space. Signed-off-by: Kai Vehmanen <[email protected]>

Add test check that correct channel is retrieved with sof_dma_request_channel(). Signed-off-by: Kai Vehmanen <[email protected]>

Prepare for other users of the standalone boot test infrastructure and do not run all tests in the sys init hook of "userspace_intel_hda_dma". Signed-off-by: Kai Vehmanen <[email protected]>

Test the SOF SSP DAI interface from a user-space thread. Implement a similar flow to configure a pair of DMA instances and a DAI device set up for both TX and RX, as is done in src/audio/dai-zephyr.c. The test does not cover running data through the DAI, as this requires separate programming of the DMA from host side, which cannot be done in this level of tests. Signed-off-by: Kai Vehmanen <[email protected]>

Update the README to cover common steps for building and running tests, and a separate section to introduce the available test cases. Signed-off-by: Kai Vehmanen <[email protected]>

kv2019i · 2025-12-12T16:16:35Z

V3:

clean rebase, no changes to the PR commits

Copilot AI review requested due to automatic review settings December 9, 2025 12:21

kv2019i requested review from RanderWang, abonislawski, dbaluta, iuliana-prodan, lbetlej, lgirdwood, lyakh, marcinszkudlinski, mmaka1, pblaszko and plbossart as code owners December 9, 2025 12:21

Copilot AI reviewed Dec 9, 2025

View reviewed changes

zephyr/test/userspace/test_intel_ssp_dai.c Outdated Show resolved Hide resolved

softwarecki reviewed Dec 9, 2025

View reviewed changes

lgirdwood approved these changes Dec 9, 2025

View reviewed changes

lyakh reviewed Dec 10, 2025

View reviewed changes

kv2019i force-pushed the 2025-user-ssp-dai branch from 2c0cb8a to 4667524 Compare December 10, 2025 19:48

lyakh approved these changes Dec 11, 2025

View reviewed changes

softwarecki approved these changes Dec 12, 2025

View reviewed changes

kv2019i added 8 commits December 12, 2025 18:04

lib: dma: add user-space support for dma_suspend/resume calls

f771da4

Extend coverage of the Zephyr DAI interface to include dma_suspend() and dma_resume() calls exposed as syscalls. This allows e.g. to run the DAI module in a user thread. Signed-off-by: Kai Vehmanen <[email protected]>

zephyr: only build sof_dma.h syscalls if enabled in build

3c0b1a7

The sof_dma.h syscalls are emitted to build whenever CONFIG_USERSPACE is set. Limit this so that the syscalls are emitted only if CONFIG_SOF_USERSPACE_INTERFACE_DMA is set. Signed-off-by: Kai Vehmanen <[email protected]>

zephyr: test: userspace: intel_hda_dma: add check for DMA channel

c4df7a8

Add test check that correct channel is retrieved with sof_dma_request_channel(). Signed-off-by: Kai Vehmanen <[email protected]>

zephyr: test: userspace: intel_hda_dma: limit which test suites are run

5e1416c

Prepare for other users of the standalone boot test infrastructure and do not run all tests in the sys init hook of "userspace_intel_hda_dma". Signed-off-by: Kai Vehmanen <[email protected]>

zephyr: test: userspace: update README to cover new tests

d5ec70d

Update the README to cover common steps for building and running tests, and a separate section to introduce the available test cases. Signed-off-by: Kai Vehmanen <[email protected]>

kv2019i force-pushed the 2025-user-ssp-dai branch from 4667524 to d5ec70d Compare December 12, 2025 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

userspace: add support to use DAIs from user threads #10421

userspace: add support to use DAIs from user threads #10421

Uh oh!

kv2019i commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

softwarecki Dec 9, 2025

Uh oh!

kv2019i Dec 10, 2025

Uh oh!

softwarecki commented Dec 9, 2025

Uh oh!

lyakh Dec 10, 2025

Uh oh!

kv2019i Dec 10, 2025 •

edited

Loading

Uh oh!

lyakh Dec 11, 2025

Uh oh!

kv2019i commented Dec 10, 2025

Uh oh!

kv2019i commented Dec 12, 2025

Uh oh!

kv2019i commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

userspace: add support to use DAIs from user threads #10421

Are you sure you want to change the base?

userspace: add support to use DAIs from user threads #10421

Uh oh!

Conversation

kv2019i commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

softwarecki Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

kv2019i Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

softwarecki commented Dec 9, 2025

Uh oh!

lyakh Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

kv2019i Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lyakh Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

kv2019i commented Dec 10, 2025

Uh oh!

kv2019i commented Dec 12, 2025

Uh oh!

kv2019i commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kv2019i Dec 10, 2025 •

edited

Loading