Add Linear embed support for projects/updates #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This does some refactoring and adds support for project URLs to extract embeds. Still to add projectUpdates into the mix.
This adds a parser so that we can process project updates with a url suffixed by `#projectUpdates-id` in the regex rules.
zuuring
changed the title
Shadowfiend
reviewed
Jan 14, 2025
| teamName?: string | ||
| projectId?: string | ||
| projectUpdateId?: string | ||
| } |
There was a problem hiding this comment.
Will this object ever have all of these fields? If not, are we looking more for a type like:
{
issueId: string
teamName?: string
commentId?: string
} |
{
projectId: string
projectUpdateId?: string
}
Shadowfiend
reviewed
Jan 14, 2025
Comment on lines
+86
to
+112
| embed | ||
| .setTitle(`Project: ${project.name}`) | ||
| .setURL( | ||
| `https://linear.app/${teamName}/project/${projectId}/overview`, | ||
| ) | ||
| .setDescription( | ||
| truncateToWords( | ||
| project.description, | ||
| "No description available.", | ||
| 50, | ||
| ), | ||
| ) | ||
| .setTimestamp(new Date(project.updatedAt)) | ||
| if (update) { | ||
| embed | ||
| .setTitle( | ||
| `Project Update: ${project.name} - ${new Date( | ||
| project.updatedAt, | ||
| ).toLocaleString()}`, | ||
| ) | ||
| .setURL( | ||
| `https://linear.app/${teamName}/project/${projectId}#projectUpdate-${projectUpdateId}`, | ||
| ) | ||
| .setDescription( | ||
| truncateToWords(update?.body, "No description available.", 50), | ||
| ) | ||
| } |
There was a problem hiding this comment.
This feels like an if/else would be less brittle than setting than overwriting.
Shadowfiend
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This does some refactoring and adds support for project URLs as well as project updates. We parse URLs with
/project/and then if suffixed by#projectUpdates-id, we embed the proper information from the project update.