dApp: Acre points UI #704
Merged
dApp: Acre points UI #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `Countdown` component, adjusted `Button` styles and mocked `useAcrePoints` hook
Changed width, added links, moved `CardButton` component to shared.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Removed (temporarily) `AcreRankCard` component
Add close button
| {/* TODO: Update `ButtonLink` component and 'link' Button theme variant */} | ||
| <Button | ||
| as={Link} | ||
| href={`${EXTERNAL_HREF.DOCS}/acre-points-program`} |
There was a problem hiding this comment.
I think it would be better to create a separate const value for this link.
src/constants/externalHref.ts
export const EXTERNAL_HREF = {
ACRE_POINTS_DOCS: "https://docs.acre.fi/acre-points-program",
...
}
r-czajkowski
previously approved these changes
Sep 18, 2024
Issue 001 -
|
| column | value before claim | value after claim |
|---|---|---|
| user_id | 0x6F1a421573082BE1BEAe22551259D4D793EfD2cE | 0x6F1a421573082BE1BEAe22551259D4D793EfD2cE |
| unclaimed | 173078298 | 0 |
| calculated_at | 2024-09-18 00:00:07 | 1726689620 |
| claimed | 0 | 173078298 |
| claimed_at | null | 1726689620 |
note calculated_at was initially stored as YYYY-MM-DD hh:mm:ss, but after claiming, stored as Unix timestamp
Can see other occurrences by querying SELECT * FROM points_balances
|
testing completed on preview-704 w/ no issues to report. |
kpyszkowski
force-pushed
the
acre-points-ui
branch
from
61e3bdb to
2254b7e
Compare
This reverts commit 414a753.
The daily points amount is capped from 100 000 000 pts to 10 000 pts (assuming the deposited amount is 1 BTC)
Closes: #735 Closes: #736 Closes: #738 Closes: #749 Intermediate state wireframes [here](https://excalidraw.com/#json=xN6XxWkT_FR4ep18xlE3l,kn9MqECigeMFp1oDMXqpVA)
kpyszkowski
force-pushed
the
acre-points-ui
branch
2 times, most recently
from
1e828bc to
3fe2b12
Compare
kkosiorowska
previously approved these changes
Oct 18, 2024
kkosiorowska
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #722
Overview:
AcrePointsCardcomponentAcrePointsClaimModalcomponentScreenshots:
Screen.Recording.2024-09-12.at.16.38.39.mov