Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flow to connect account before opening modal windows #414

Merged
merged 5 commits into from
May 17, 2024

Conversation

kkosiorowska
Copy link
Contributor

@kkosiorowska kkosiorowska commented May 10, 2024

⚠️ Merge available after #408 ⚠️

Refs #394

This PR creates a special hook for triggering TransactionModal. After clicking on the “Deposit BTC” button, we should first call the Ledger Live native window to select an account. Once the account has been selected we open the right transaction modal to the user.

@kkosiorowska kkosiorowska self-assigned this May 10, 2024
@kkosiorowska kkosiorowska changed the title Create New flow to connect account before opening modal windows May 10, 2024
After clicking on the “Deposit BTC” button, we should first call the Ledger Live native window to select an account. Once the account has been selected we open the right transaction modal to the user.
@kkosiorowska kkosiorowska force-pushed the new-account-connection-flow branch from de2fbb8 to 5df4b8a Compare May 10, 2024 09:24
@kkosiorowska kkosiorowska marked this pull request as ready for review May 10, 2024 09:26
Base automatically changed from update-transaction-modal to main May 15, 2024 06:53
Copy link

netlify bot commented May 16, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 83d1799
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/6646ec62fb33b000080ee16f
😎 Deploy Preview https://deploy-preview-414--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

r-czajkowski
r-czajkowski previously approved these changes May 16, 2024
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left one minor comment.

@r-czajkowski r-czajkowski merged commit 7ac623a into main May 17, 2024
25 checks passed
@r-czajkowski r-czajkowski deleted the new-account-connection-flow branch May 17, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants