Add opensssl extension as a required dependency

[martin-rueegg]

Added a dependency in composer.json ...

Autoload/composer.json

Line 6 in e1b5f8c

"ext-openssl": "*",

... due to the usage of openssl_pkey_export and openssl_pkey_get_details in

Autoload/src/PharBuilder.php

Lines 98 to 100 in 9235b07

	openssl_pkey_export($this->key, $privateKey);
	$phar->setSignatureAlgorithm(\Phar::OPENSSL, $privateKey);
	$keyDetails = openssl_pkey_get_details($this->key);

[martin-rueegg]

Hi @theseer

Any chance to look at this for feedback or comments?

Thanks,
Martin.

[martin-rueegg]

Awesome, thanks!

[theseer]

Sorry for taking long.

Actually, the extension is only required when you make use of the openssl signing feature. So, in that sense it's optional. But I didn't properly implement that as optional. I was even considering to remove the openssl feature as it's pretty useless.

[martin-rueegg]

Sorry for taking long.

No worries. Appreciating your time!

Actually, the extension is only required when you make use of the openssl signing feature. So, in that sense it's optional. But I didn't properly implement that as optional. I was even considering to remove the openssl feature as it's pretty useless.

I see. I only noticed it since my IDE complained ... :-)

I can't recall if I was actually using the related functionality!