Skip to content

Conversation

@LumiFae
Copy link

@LumiFae LumiFae commented Jan 13, 2026

🔗 Related issue (optional)

Closes #1913


📑 Description

Adds the oninput property to the TableSearch component.


🔍 PR Type

  • Bug fix
  • Feature
  • Documentation
  • Refactor / Code cleanup
  • Build / Tooling
  • Other (please describe)

🚦 PR Status

  • Draft (work in progress, not ready for review)
  • Ready for review ✅

✅ Checklist

  • My code follows the existing code style
  • I have run pnpm lint && pnpm check && pnpm test:e2e and all tests pass
  • CoderabbitAI review has been completed and actionable suggestions were reviewed
  • I have updated documentation if my changes require it
  • My PR is based on the latest main branch (not the published npm version)
  • I have checked accessibility where applicable (ARIA, keyboard nav, etc.)
  • I have reviewed the rendered component in the browser

Summary by CodeRabbit

New Features

  • TableSearch component now supports custom input event handlers, allowing direct capture and real-time processing of search input changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

A new oninput event handler property is added to the TableSearch component, enabling external handlers to respond directly to input events. This prop is declared in the component interface and bound to the input element's oninput attribute.

Changes

Cohort / File(s) Summary
TableSearch Component Type Definition
src/lib/types.ts
Added optional oninput: (event: Event) => void property to TableSearchProps interface
TableSearch Component Implementation
src/lib/table/TableSearch.svelte
Added public oninput prop with component declaration and binding to input element's oninput attribute

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A whisker-twitch of oninput cheer,
No effects needed, handlers so clear!
Input events flow straight and true,
Developer joy through and through! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: oninput event' clearly and concisely describes the main feature addition to the TableSearch component.
Linked Issues check ✅ Passed The PR successfully implements the objective from issue #1913 by adding the oninput prop to TableSearch component and exposing it on the input field [#1913].
Out of Scope Changes check ✅ Passed All changes are scoped to the stated objective: adding oninput property to TableSearch component via updates to TableSearch.svelte and types.ts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description follows the template structure with all required sections completed, including related issue, clear description, PR type selection, status, and comprehensive checklist confirmation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Jan 13, 2026

@LumiFae is attempting to deploy a commit to the Bergside Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add oninput to TableSearch's input field

1 participant