Merge pull request #19 from NicolasBarbey/main

Fix module for php8
thelia-modules · Aug 27, 2021 · c0ffd70 · c0ffd70
2 parents 7405e60 + 171582d
commit c0ffd70
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/BetterSeo.php b/BetterSeo.php
@@ -30,11 +30,10 @@ class BetterSeo extends BaseModule
      */
     public function postActivation(ConnectionInterface $con = null):void
     {
-        try {
-            BetterSeoQuery::create()->findOne();
-        } catch (\Exception $e) {
+        if (!self::getConfigValue('is_initialized',null)){
             $database = new Database($con);
             $database->insertSql(null, [__DIR__ . "/Config/thelia.sql"]);
+            self::setConfigValue('is_initialized', 1);
         }
     }
 

diff --git a/Config/module.xml b/Config/module.xml
@@ -13,7 +13,7 @@
         <language>en_US</language>
         <language>fr_FR</language>
     </languages>
-    <version>2.0.1</version>
+    <version>2.0.2</version>
     <authors>
         <author>
             <name>Nicolas Barbey</name>

diff --git a/Smarty/Plugins/BetterSeoMicroDataPlugin.php b/Smarty/Plugins/BetterSeoMicroDataPlugin.php
@@ -78,7 +78,11 @@ public function betterSeoMicroData($params)
             case 'product':
                 $id = $params['id'] ?? $this->request->get('product_id');
                 $product = ProductQuery::create()->filterById($id)->findOne();
-                $relatedProducts = \is_array($params['related_products']) ? $params['related_products'] : $this->explode($params['related_products']);
+                $relatedProducts = null;
+
+                if (array_key_exists('related_products', $params)){
+                    $relatedProducts = \is_array($params['related_products']) ? $params['related_products'] : $this->explode($params['related_products']);
+                }
 
                 $microdata = $this->getProductMicroData($product, $lang, $relatedProducts);
                 break;