Fix invalid loop argument + missing isset for plugin params

thelia-modules · Jul 16, 2021 · b56a714 · b56a714
1 parent 5160b36
commit b56a714
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Hook/MetaHook.php b/Hook/MetaHook.php
@@ -19,7 +19,8 @@ public function __construct(RequestStack $requestStack)
 
     public function onMainHeadBottom(HookRenderEvent $event)
     {
-        if($view = $this->request->get('_view')) {
+        $view = $this->request->get('_view');
+        if ($view && preg_match('#^[a-zA-Z0-9\-_\.]+$#', $view)) {
 
             $id = $this->request->get($view . '_id');
 

diff --git a/Smarty/Plugins/BetterSeoMicroDataPlugin.php b/Smarty/Plugins/BetterSeoMicroDataPlugin.php
@@ -65,7 +65,7 @@ public function getPluginDescriptors()
      */
     public function betterSeoMicroData($params)
     {
-        $type = $params['type'] ?: $this->request->get('_view');
+        $type = $params['type'] ?? $this->request->get('_view');
 
         $lang = $this->request->getSession()->getLang();