Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 support #794

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Python 3.12 support #794

wants to merge 9 commits into from

Conversation

Lilly-May
Copy link
Collaborator

@Lilly-May Lilly-May commented Aug 29, 2024 •
edited
Loading

PR Checklist

Description of changes

  • Updated CI tests to Python 3.12
  • Added graphviz as a dependency for the docs since it's required in the causal inference notebook
  • Fixed data retrieval for the causal effect estimator in ep.pl.causal_effect(estimate). This change is necessary because dowhy currently does not support Python 3.12 (see here). The most recent version of dowhy compatible with Python 3.12 is 0.8, which stores the _data attribute in the estimator instead of the estimate. We can remove the conditional data retrieval as soon as dowhy supports Python 3.12.

@github-actions github-actions bot added the enhancement New feature or request label Aug 29, 2024
@Lilly-May Lilly-May marked this pull request as ready for review August 29, 2024 13:53
@Lilly-May Lilly-May requested a review from Zethson August 29, 2024 13:53
Zethson
Zethson reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's wait for the dowhy release and remove the compatibility code, please.

.github/workflows/run_notebooks.yml Outdated Show resolved Hide resolved
@Lilly-May Lilly-May marked this pull request as draft August 29, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check ehrapy compatibility with Python 3.12
2 participants
@Lilly-May @Zethson