Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tutorials #35

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adjust tutorials #35

wants to merge 5 commits into from

Conversation

eroell
Copy link
Contributor

@eroell eroell commented Oct 30, 2024

See theislab/ehrapy#811 on ehrapy repo

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@eroell eroell changed the title Harmonize MIMIC-II IAC title intro Adjust tutorials Oct 30, 2024
eroell
eroell commented Oct 30, 2024
View reviewed changes
mimic_2_fate.ipynb
@@ -5,7 +5,7 @@
"id": "70954479-ed2d-4bdb-90ca-5d607019e5b9",
Copy link
Contributor Author

@eroell eroell Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be double checked if the original description is still up to date regarding cluster numbers?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who should I ask here @Zethson ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me? idk^^ the dataset is simple and we just look at it ourselves. Did the numbers look wrong, change or are fishy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they look fishy to me, and I wonder if the leiden clusters changed from when this text was written

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally possible. But unfortunately, it'd be you (us) that has to look at them. No expert involved.

@eroell eroell requested a review from Zethson October 30, 2024 16:37
@eroell eroell marked this pull request as ready for review October 30, 2024 16:37
Zethson
Zethson approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a better idea for linking it. Submodule is too heavy because of all of the rest that we don't care about. Alternatively, we would link it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eroell @Zethson