-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tutorials #35
base: main
Are you sure you want to change the base?
Adjust tutorials #35
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -5,7 +5,7 @@ | |||
"id": "70954479-ed2d-4bdb-90ca-5d607019e5b9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be double checked if the original description is still up to date regarding cluster numbers?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who should I ask here @Zethson ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me? idk^^ the dataset is simple and we just look at it ourselves. Did the numbers look wrong, change or are fishy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they look fishy to me, and I wonder if the leiden clusters changed from when this text was written
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally possible. But unfortunately, it'd be you (us) that has to look at them. No expert involved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a better idea for linking it. Submodule is too heavy because of all of the rest that we don't care about. Alternatively, we would link it.
See theislab/ehrapy#811 on ehrapy repo