This repository was archived by the owner on Sep 24, 2022. It is now read-only.
Added README template and template guide for review#248
Open
fungjoanne wants to merge 1 commit intothegooddocsproject:devfrom
Open
Added README template and template guide for review#248fungjoanne wants to merge 1 commit intothegooddocsproject:devfrom
fungjoanne wants to merge 1 commit intothegooddocsproject:devfrom
Conversation
barbaricyawps
suggested changes
Jun 9, 2022
Contributor
barbaricyawps
left a comment
There was a problem hiding this comment.
FYI, I leave feedback using the Conventional Comments method: https://conventionalcomments.org/
Praise: Joann, this whole template is AMAZING already! I have a few suggestions, but so much of this is really strong as it is. Very, very nice work!
blerko
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
soliloquizin
left a comment
There was a problem hiding this comment.
Great template (and guide), very helpful!
Cristabell
reviewed
Sep 11, 2022
Cristabell
reviewed
Sep 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template quality checklist
This quality checklist will eventually become a pull request template that every contributor needs to add to pull requests against the
templatesrepository.Pull request summary
{Describe the purpose of your pull request.}
{Also indicate which template working group you belong to and who your template mentor is.}
Template contributor checklist
IMPORTANT: The next three sections in this checklist should be filled out by the template contributor at the time they submit this request.
NOTE: Pull requests can only be merged when all boxes are checked.
Which issue does this pull request fix or reference?
This pull request:
Procedural requirements
Template set requirements
Template pull request reviewer checklist
IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized Good Docs Project pull request reviewers. If you are the individual template contributor, do not fill out the rest of the fields or check the boxes.
NOTE: Pull requests can only be merged when all boxes are checked.
Mechanics and formatting requirements - PULL REQUEST REVIEWER ONLY
Overall usability - PULL REQUEST REVIEWER ONLY
Template file requirements - PULL REQUEST REVIEWER ONLY
Template guide requirements - PULL REQUEST REVIEWER ONLY
Deep dive requirements (optional) - PULL REQUEST REVIEWER ONLY
Template example requirements (optional) - PULL REQUEST REVIEWER ONLY