-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend VMWare image provisioning documentation #1523
base: gh-pages
Are you sure you want to change the base?
Conversation
…sh - extend finish information as new bullet point
If my way of documentation is ok, I can add it to latest, too. In future, should I do this the other way round? (first latest, then 1.x) |
@ezr-ondrej can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bit of more fancy wording, I suggested some, but not a native speaker, so no hard feelings if you don't agree, but otherwise nice addition, thanks 👍
Ok I will do an update to the latest documentation, too. I will take the new fancy words for that :) |
What's the status? |
Co-authored-by: Ondřej Ezr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lemme squash this, thank you!
Okay this needs to be rebased and single commit and the change must be done against the nightly file, can you do that please? diff --git a/_includes/manuals/nightly/5.2.8_cr_vmware.md b/_includes/manuals/nightly/5.2.8_cr_vmware.md
index fcb79a736..12d4ee561 100644
--- a/_includes/manuals/nightly/5.2.8_cr_vmware.md
+++ b/_includes/manuals/nightly/5.2.8_cr_vmware.md
@@ -17,6 +17,7 @@ The same process can also be done using a user_data template. To configure image
* Browse then to the image to be used for provisioning, and ensure that "User Data" is checked
* Associate a user_data template to the host. The template will use cloud-init syntax.
* Note that the images don't need cloudinit installed, as the cloudinit is converted under the hood to a CustomisationSpec object that VMware can process
+* In order to inform foreman about successful build and get the host to "Installed" state in the UI, the provisioned host have to run a finish script. You can Thanks! |
Extend VMWare documentation. Image provisioning information without ssh - extend finish information as new bullet point