Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the order of the code preparation and code tagging steps #390

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jul 15, 2024

Until a release has been tagged, things can still be added and the bot could set the wrong Fixed in Release values. The Redmine steps should be done after.

Until a release has been tagged, things can still be added and the bot
could set the wrong Fixed in Release values.
This keeps the tagging step to just tagging.
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense!

@ekohl ekohl merged commit 8257e84 into theforeman:master Jul 15, 2024
3 checks passed
@ekohl ekohl deleted the fix-code-steps branch July 15, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants