Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct whitespace on the website instructions #264

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 4, 2023

No description provided.

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So will this still be indented under Update theforeman.org?

@ekohl
Copy link
Member Author

ekohl commented Sep 6, 2023

For me the best way to review this was to try out the various forms:

./procedure release --project foreman --version 3.8.0 --target-date 2024-01-01 --owner X --engineer X
./procedure release --project foreman --version 3.8.0-rc1 --target-date 2024-01-01 --owner X --engineer X
./procedure release --project foreman --version 3.8.0-rc2 --target-date 2024-01-01 --owner X --engineer X
./procedure release --project foreman --version 3.8.1 --target-date 2024-01-01 --owner X --engineer X

It's just printing things to stdout, so it's perfectly safe to try it. It's also how I found 65732ea as a bug.

@ekohl ekohl merged commit ac21d3f into theforeman:master Sep 6, 2023
3 checks passed
@ekohl ekohl deleted the fix-theforeman-org-instructions branch September 6, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants