Skip to content

Dynflow Sidekiq service file can be managed via puppet #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Dynflow Sidekiq service file can be managed via puppet #1192

wants to merge 8 commits into from

Conversation

highpingblorg
Copy link

Fixes issue #1191

ekohl
ekohl requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading the full definition is not something I'd want. Systemd has drop in files you can place. Why can't they be used to override only what you need?

@highpingblorg
Copy link
Author

@ekohl Modified my implementation to use systemd drop in files as requested.

If there is anything else I should change, let me know!

@highpingblorg highpingblorg requested a review from ekohl October 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl Awaiting requested review from ekohl

Assignees
No one assigned
Labels
Needs re-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@highpingblorg @ekohl