Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try db_password to be Sensitive #1190

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

try db_password to be Sensitive #1190

wants to merge 3 commits into from

Commits on Oct 16, 2024

  1. properly escape quotes in passwords by calling to_ruby 

    database passwords can contain special characters, especially " and '
so we can't just print the value of the field enclosed by double quotes
as that would break whenever the user uses a literal " in their password

using to_ruby here and not to_yaml, as the former gives us correct escaping
without the whole `---` and `\n` enclosing that to_yaml forces.
using to_yaml would require to pass *the whole* config hash to it
    @evgeni
    evgeni committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    95133be View commit details
    Browse the repository at this point in the history

  2. try db_password to be Sensitive

    @evgeni
    evgeni committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8903ba2 View commit details
    Browse the repository at this point in the history

  3. sensitive?!

    @evgeni
    evgeni committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a2f3872 View commit details
    Browse the repository at this point in the history