Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet 8 support #1126

Closed
wants to merge 3 commits into from
Closed

Conversation

bastelfreak
Copy link
Member

also contains #1125

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs to be updated for it to run tests on Puppet 8.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs #1133 so it actually runs CI.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all fixes are in place. Please rebase.

The `ensure_packages()` function is deprecated. The successor is
`stdlib::ensure_packages().
@ekohl
Copy link
Member

ekohl commented Nov 7, 2023

I did notice there were deprecation warnings about the ERB template:

ERB.new(File.read(File.expand_path("_header.erb",File.dirname(file))), nil, nil, "@header").result(binding) -%>

This needs to use keyword arguments now (and is repeated in multiple files).

@bastelfreak
Copy link
Member Author

@ekohl rebased on #1125

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is relevant. I think the exception needs to be changed to a general Puppet::Error instead of a ParseError.

@ekohl
Copy link
Member

ekohl commented Nov 13, 2023

I think #1139 should be complete. I've opted to drop the deprecated non-namespaced functions instead of trying to fix them.

@ekohl ekohl closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants