Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the config file compatible with 0.2.z and 0.4.z #8

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

adamruzicka
Copy link
Collaborator

  • broker is an array of mqtt servers used by 0.2
  • server is an array of mqtt servers used by 0.4
  • data-host needs to be set to an empty string to override certain compile-time defaults set in RHEL and CentOS Stream
  • prefix needs to be set to the value we expect to override certain compile-time defaults set in RHEL and CentOS Stream

@pondrejk
Copy link

Tested the old-style yggdrasil clients via prt run in SatelliteQE/robottelo#16690, tested manually for new style yggdrasil client

The service name changed between the package we shipped and official 0.4.z
builds, these changes account for this discrepancy.

Config file changes:
- broker is an array of mqtt servers used by 0.2
- server is an array of mqtt servers used by 0.4
- data-host needs to be set to an empty string to override certain compile-time
  defaults set in RHEL and CentOS Stream
- path-prefix needs to be set to the value we expect to override certain compile-time
  defaults set in RHEL and CentOS Stream

broker and server can be set at both once, each will be honored by their
respective versions

data-host and path-prefix can be set both at once on our build of yggdrasil they'll
just duplicate the defaults, on RHEL/CentOS Stream they'll act as overrides
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamruzicka and @pondrejk !

@adamruzicka adamruzicka merged commit 131d084 into theforeman:develop Oct 31, 2024
1 check passed
@adamruzicka adamruzicka deleted the extended-compat branch October 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants