Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy website to website01 #510

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

deploy website to website01 #510

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 28, 2024

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wondering about using the GitHub deployments API as well. Mostly because there's a more direct view of what was deployed in our PRs. Have you used https://docs.github.com/en/actions/use-cases-and-examples/deploying/deploying-with-github-actions in the past?

Also, it made me look at this file and noticed we made some preparations for the CDN but didn't activate it when we turned on the CDN:

sh "cat '${rsync_log}'"
// this should become something like this later:
// sh "awk '/ CHANGED /{print $5}' '${rsync_log}' | xargs --no-run-if-empty fastly-purge 'https://theforeman.org/'"
sh "rm '${rsync_log}'"

Should we do that now?

@evgeni
Copy link
Member Author

evgeni commented Nov 28, 2024

I've been wondering about using the GitHub deployments API as well. Mostly because there's a more direct view of what was deployed in our PRs. Have you used https://docs.github.com/en/actions/use-cases-and-examples/deploying/deploying-with-github-actions in the past?

I did not (and didn't plan to do that overhaul right now)

Also, it made me look at this file and noticed we made some preparations for the CDN but didn't activate it when we turned on the CDN:

sh "cat '${rsync_log}'"
// this should become something like this later:
// sh "awk '/ CHANGED /{print $5}' '${rsync_log}' | xargs --no-run-if-empty fastly-purge 'https://theforeman.org/'"
sh "rm '${rsync_log}'"

Should we do that now?

That's unrelated to which backend the CDN uses, but yes.

@evgeni
Copy link
Member Author

evgeni commented Nov 28, 2024

#512

@ekohl
Copy link
Member

ekohl commented Nov 28, 2024

I did not (and didn't plan to do that overhaul right now)

I took a stab at it in theforeman/theforeman.org#2206. What we could even do is to have both in place for a time: GHA for the new host and Jenkins for the old host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants