-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy website to website01 #510
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wondering about using the GitHub deployments API as well. Mostly because there's a more direct view of what was deployed in our PRs. Have you used https://docs.github.com/en/actions/use-cases-and-examples/deploying/deploying-with-github-actions in the past?
Also, it made me look at this file and noticed we made some preparations for the CDN but didn't activate it when we turned on the CDN:
jenkins-jobs/theforeman.org/pipelines/deploy/website.groovy
Lines 35 to 38 in 4a0b9c2
sh "cat '${rsync_log}'" | |
// this should become something like this later: | |
// sh "awk '/ CHANGED /{print $5}' '${rsync_log}' | xargs --no-run-if-empty fastly-purge 'https://theforeman.org/'" | |
sh "rm '${rsync_log}'" |
Should we do that now?
I did not (and didn't plan to do that overhaul right now)
That's unrelated to which backend the CDN uses, but yes. |
I took a stab at it in theforeman/theforeman.org#2206. What we could even do is to have both in place for a time: GHA for the new host and Jenkins for the old host. |
No description provided.