Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

centos7 and centos8 name update #1832

Merged
merged 2 commits into from
Sep 20, 2024
Merged

centos7 and centos8 name update #1832

merged 2 commits into from
Sep 20, 2024

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver marked this pull request as ready for review July 12, 2024 11:34
@archanaserver archanaserver mentioned this pull request Jul 12, 2024
Closed
3 tasks
@archanaserver archanaserver marked this pull request as draft July 12, 2024 13:11
@archanaserver
Copy link
Contributor Author

Marked this as draft for now. I'll take a look on this once again once #1826 gets merged.

@archanaserver archanaserver mentioned this pull request Jul 12, 2024
Closed
5 tasks
ekohl
ekohl requested changes Jul 12, 2024
View reviewed changes
docs/library.md Outdated Show resolved Hide resolved
docs/production.md Outdated Show resolved Hide resolved
docs/production.md Outdated Show resolved Hide resolved
docs/production.md Outdated Show resolved Hide resolved
docs/provision.md Outdated Show resolved Hide resolved
roles/foreman_provisioning/tasks/configure_centos_7.yml Outdated Show resolved Hide resolved
roles/foreman_provisioning/tasks/configure_centos_7.yml Outdated Show resolved Hide resolved
roles/foreman_provisioning/tasks/configure_centos_7.yml Outdated Show resolved Hide resolved
roles/katello_provisioning/tasks/main.yml Show resolved Hide resolved
vagrant/boxes.d/01-builtin.yaml Outdated Show resolved Hide resolved
@archanaserver archanaserver marked this pull request as ready for review July 15, 2024 10:59
@archanaserver archanaserver force-pushed the drop-centos7 branch 3 times, most recently from af4859d to f25d128 Compare July 16, 2024 07:53
ekohl
ekohl previously requested changes Jul 16, 2024
View reviewed changes
docs/provision.md Outdated Show resolved Hide resolved
docs/provision.md Outdated Show resolved Hide resolved
packer/README.md Outdated Show resolved Hide resolved
roles/foreman_provisioning/tasks/configure_centos_9.yml Outdated Show resolved Hide resolved
roles/katello_provisioning/tasks/main.yml Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Jul 16, 2024

#1833 created conflicts here.

@archanaserver
Copy link
Contributor Author

Thanks @ekohl, as per the review, I've made some changes.

ekohl
ekohl reviewed Jul 17, 2024
View reviewed changes
packer/README.md Outdated Show resolved Hide resolved
packer/README.md Show resolved Hide resolved
roles/katello_provisioning/tasks/main.yml Outdated Show resolved Hide resolved
roles/foreman_provisioning/tasks/configure_centos_9.yml Outdated Show resolved Hide resolved
@archanaserver
Copy link
Contributor Author

this is just a note- i'll continue working on this PR once #1826 is merged. i got a bit confused and i guess, i might have mixed up some changes 😕

@ekohl ekohl mentioned this pull request Jul 19, 2024
Open
@archanaserver archanaserver force-pushed the drop-centos7 branch 3 times, most recently from a36d9ba to a31e6e3 Compare September 4, 2024 06:56
@archanaserver archanaserver marked this pull request as draft September 4, 2024 06:57
@archanaserver archanaserver force-pushed the drop-centos7 branch 5 times, most recently from fea41a3 to 6f8acb7 Compare September 9, 2024 20:43
@archanaserver archanaserver changed the title Drop CentOS 7 boxes centos7 and centos8 name update Sep 9, 2024
@archanaserver archanaserver mentioned this pull request Sep 9, 2024
Closed
@archanaserver
Copy link
Contributor Author

Note: I'll have to test the changes once again.

@archanaserver archanaserver marked this pull request as ready for review September 10, 2024 18:07
@archanaserver archanaserver mentioned this pull request Sep 10, 2024
Merged
@evgeni
Copy link
Member

evgeni commented Sep 20, 2024

needs a rebase now that #1856 is merged

evgeni
evgeni requested changes Sep 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/development.md Show resolved Hide resolved
@evgeni evgeni dismissed ekohl’s stale review September 20, 2024 06:38

all requested changes were made

@evgeni evgeni merged commit 27c5d83 into theforeman:master Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@archanaserver @ekohl @evgeni @chris1984