Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RuboCop and enable in CI #1606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update RuboCop and enable in CI #1606

wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 17, 2022

Follow up on #1605. Ruby 2.5 was chosen because EL8 ships Ruby 2.5 by default.

ekohl
ekohl commented Nov 17, 2022
View reviewed changes
vagrant/Rakefile Outdated Show resolved Hide resolved
@ekohl ekohl marked this pull request as draft November 17, 2022 13:30
@ekohl ekohl force-pushed the rubocop-update branch 2 times, most recently from edfbeea to 38ae935 Compare November 17, 2022 15:11
@ekohl ekohl marked this pull request as ready for review November 17, 2022 15:11
@ekohl
Copy link
Member Author

ekohl commented Nov 17, 2022

No idea why the annotations aren't working, but this is otherwise working as intended.

wbclark
wbclark reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl

Should this be called something like "enable rubocop in CI" ? I would be in favor of doing so.

I would like to look at this but the logs are expired and there are merge conflicts now. Would you consider this important enough to revisit?

@ekohl ekohl changed the title Set Ruby 2.5 as the minimum version Update RuboCop Aug 23, 2023
@ekohl ekohl changed the title Update RuboCop Update RuboCop and enable in CI Aug 23, 2023
@ekohl
Copy link
Member Author

ekohl commented Aug 23, 2023

I'm updating this, but now that I see it I saw a note about EL8 having Ruby 2.5 by default. I wonder if that's a concern for our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbclark wbclark wbclark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @wbclark