Don't overwrite katello-devel-answers.yaml #1604
Conversation
wbclark
force-pushed
the
devel-answers
branch
from
80d5766
to
d785945
Compare
|
Test failure unrelated but #1605 should fix that |
This allows re-running the provisioner without overwriting the user's changes to the configuration, so that the installer in devel setups more closely matches the familiar standard behavior.
wbclark
force-pushed
the
devel-answers
branch
from
d785945
to
b1a82fc
Compare
|
Tests are now 🍏 |
| @@ -16,10 +16,11 @@ | |||
| with_items: | |||
| - katello-devel.yaml | |||
|
|
|||
| - name: 'Copy answers file' | |||
| - name: "Create devel scenario answers file if it doesn't already exist" | |||
There was a problem hiding this comment.
This will result in some options to this role only affecting the first run of the role and then never again -- that is generally an unexpected situation for Ansible roles.
If we are going this route, I should think we need to go all the way and make it such that the dynamic values we do have (https://github.com/theforeman/forklift/blob/master/roles/foreman_installer_devel_scenario/templates/katello-devel-answers.yaml#L3-L8) get passed to the installer as parameters.
There was a problem hiding this comment.
Thanks, I pushed an additional commit which moves these dynamic values out of the answers file and into foreman_installer_options_internal_use_only, which is probably where they should have been all along. (What clown put dynamic values in the answers file? Oh right, it's me. I'm the clown.)
So, the behavior should now be consistent with what you expect from an ansible role. Updating the foreman_installer_devel_scenario_user or foreman_installer_devel_scenario_group will again properly result in the installer making the appropriate changes.
I also removed generate and deploy from the certs params in the answers file, because the values we were passing were already the defaults for that module, so I couldn't see any reason why those needed to be there. I can revert that if it's needed for any reason.
I've tested this in my own setup, which does include a non-default value for foreman_installer_devel_scenario_user and it's all working just fine for me.
| template: | ||
| src: "{{ role_path }}/templates/{{ item }}" | ||
| dest: /etc/foreman-installer/scenarios.d/{{ item }} | ||
| force: no |
There was a problem hiding this comment.
@ehelms would the benefit from being toggle-able? force: yes (i.e. the old behavior, which is the default when force is omitted entirely) would be the default but the user could specify instead not to overwrite with a variable like foreman_installer_devel_scenario_dont_overwrite_answers_file)
This allows re-running the provisioner without overwriting the user's changes to the configuration, so that the installer in devel setups more closely matches the familiar standard behavior.