Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support deploying with custom certs #1461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support deploying with custom certs #1461

wants to merge 2 commits into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 26, 2022

No description provided.

ekohl
ekohl reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, ownca here should not be confused with Ansible's ownca in https://docs.ansible.com/ansible/latest/collections/community/crypto/x509_certificate_module.html

@ehelms
Copy link
Member

ehelms commented Jan 26, 2022

Could you consider reducing duplication by consolidating the role we have already for doing this? https://github.com/theforeman/forklift/tree/master/roles/custom_certificates

@evgeni
Copy link
Member Author

evgeni commented Jan 26, 2022

TIL: we already had something for that…

@evgeni evgeni mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ehelms @ekohl