Refactor BaseDatabase class for simplicity #945
+221
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration is an instance level setting that is never passed in. This simplifies the code by avoiding the need to pass it around.
This avoids needing to use a shell.
This avoids the need to build a complex command. On the plus side, it avoids the risk of leaking anything about the database access. On the downside, that can make debugging harder.
This avoids the need for another helper command and simplifies the commands.
This matches other queries.
This uses a block that won't run if @deb_postgresql_versions is already set.
This wasn't used in the past for Ruby 1.9 or 2.0 support, but we can now rely on this. It makes testing easier.
ekohl
force-pushed
the
clean-up-base-db
branch
from
c709f56
to
d3d4932
Compare
ekohl
force-pushed
the
clean-up-base-db
branch
from
d3d4932
to
9bed8ed
Compare
evgeni
reviewed
Oct 18, 2024
| 'PGHOST' => configuration.fetch('host', 'localhost'), | ||
| 'PGPORT' => configuration.fetch('port', '5432'), | ||
| 'PGUSER' => configuration.fetch('username'), | ||
| 'PGPASSWORD' => configuration[%(password)], |
There was a problem hiding this comment.
Suggested change
| 'PGPASSWORD' => configuration[%(password)], | |
| 'PGPASSWORD' => configuration['password'], |
There was a problem hiding this comment.
I kept that from the previous implementation, but I agree that if we focus on simplicity that we should also apply it here.
There was a problem hiding this comment.
There it was just to escape (lol) quoting hell because of
"PGPASSWORD='#{config[%(password)]}' "
Here it's just weird :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to make the BaseDatabase class easier to follow. At this point it's untested, but it was inspired by #939. At this point it's untested and not everything may make sense. It's structured as smaller commits that should be fairly straight forward to follow.