Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37166 - Add procedure to remove corrupted host statuses #798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #37166 - Add procedure to remove corrupted host statuses #798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions definitions/procedures/foreman/remove_corrupted_host_statuses.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
module Procedures::Foreman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not included in any scenarios - where are you wanting it to run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Actually I was unsure if we want to have this to run on every upgrade or backup or other places.
The procedures can be called as a single routine and I think it make sense to have a collection of these "maintenance" routines which can solve issues. What are your thougths?

class RemoveCorruptedHostStatuses < ForemanMaintain::Procedure
metadata do
for_feature :foreman_database
description 'Remove corrupted host statuses'
end

def run
corrupted = collect_host_status_with_type_nil
if corrupted.empty?
skip("No corrupted host status. Everything fine. Exit.")
end

print("Detected corrupted host statuses:\n")
corrupted.each do |s|
print("Host #{s['host_name']} has corrupted host_status with id #{s['host_status_id']}\n")
end

answer = ask_decision("Do you want to remove the statuses", actions_msg: 'y(yes), q(quit)')
abort! unless answer == :yes

with_spinner('Removing corrupted host statuses') do
delete_host_status_with_type_nil
end
end

private

def collect_host_status_with_type_nil
feature(:foreman_database).query(
"SELECT hosts.name AS host_name, host_status.id AS host_status_id
FROM hosts, host_status
WHERE host_status.type IS NULL AND hosts.id = host_status.host_id"
)
end

def delete_host_status_with_type_nil
feature(:foreman_database).psql(
"DELETE FROM host_status WHERE type IS NULL"
)
end
end
end
Loading