Fixes #35145 - strip out + and ~ from package versions

lib/foreman_maintain/concerns/system_helpers.rb

@@ -143,6 +143,9 @@ def shellescape(string)
       end
 
       def version(value)
+        # packages versions, especially on Debian, sometimes include a + or a ~,
+        # but Gem::Version can't handle that.
+        value.gsub!(/[+~]/, '-')
         Version.new(value)
       end
 

test/lib/concerns/system_helpers_test.rb

@@ -0,0 +1,22 @@
+require 'test_helper'
+
+class FakeSystem
+  include ForemanMaintain::Concerns::SystemHelpers
+end
+
+module ForemanMaintain
+  describe Concerns::SystemHelpers do
+    let(:system) { FakeSystem.new }
+
+    describe '.version' do
+      it 'can parse a normal version' do
+        assert system.version('1.2.3')
+      end
+
+      it 'can parse a weird nightly package version' do
+        assert system.version('9999-3.4.0-bullseye+scratchbuild+20220623140206')
+        assert system.version('1.4.7-1~tfm+1')
+      end
+    end
+  end
+end