Conflict satellite-maintain < 0.0.3

[evgeni]

In foreman_maintain 1.8.0 we moved some Satellite-specific metadata to
the Satellite-specific satellite-maintain package, but the normal
upgrade procedure doesn't enforce the right satellite-maintain version
to be present, thus leading to upgrade errors. Let's enforce this
requirement at the package level.

[evgeni]

No satellite-maintain:

# dnf install ./rubygem-foreman_maintain-1.8.1-2.el9.noarch.rpm 
Last metadata expiration check: 0:00:38 ago on Thu Oct 24 06:26:40 2024.
Dependencies resolved.
=======================================================================================================================================================================================================================================
 Package                                                           Architecture                                    Version                                                 Repository                                             Size
=======================================================================================================================================================================================================================================
Upgrading:
 rubygem-foreman_maintain                                          noarch                                          1:1.8.1-2.el9                                           @commandline                                          148 k

Transaction Summary
=======================================================================================================================================================================================================================================
Upgrade  1 Package

Total size: 148 k

satellite-maintain-0.0.2:

# dnf install ./rubygem-foreman_maintain-1.8.1-2.el9.noarch.rpm 
Last metadata expiration check: 0:01:27 ago on Thu Oct 24 06:26:40 2024.
Error: 
 Problem: package rubygem-foreman_maintain-1:1.8.1-2.el9.noarch from @commandline requires (satellite-maintain >= 0.0.3 if satellite-maintain), but none of the providers can be installed
  - conflicting requests
  - problem with installed package satellite-maintain-0.0.2-1.el9sat.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

satellite-maintain-0.0.3:

# dnf install ./rubygem-foreman_maintain-1.8.1-2.el9.noarch.rpm 
Last metadata expiration check: 0:02:32 ago on Thu Oct 24 06:26:40 2024.
Dependencies resolved.
=======================================================================================================================================================================================================================================
 Package                                                           Architecture                                    Version                                                 Repository                                             Size
=======================================================================================================================================================================================================================================
Upgrading:
 rubygem-foreman_maintain                                          noarch                                          1:1.8.1-2.el9                                           @commandline                                          148 k

Transaction Summary
=======================================================================================================================================================================================================================================
Upgrade  1 Package

Total size: 148 k

[evgeni]

Repoclosure complains about this, which I don't understand, as the if satellite-maintain part should filter it out…

We could use the same "hack" we did in foreman_theme_satellite:

foreman-packaging/packages/satellite/rubygem-foreman_theme_satellite/rubygem-foreman_theme_satellite.spec

Line 6 in 0baf56d

%global downstream_build ("%{?dist}" == ".el8sat" || "%{?dist}" == ".el9sat")

But I hoped this is not necessary 😞

[pcreech]

Looks like the repoclosure issue is a "known issue" in DNF world at least: rpm-software-management/dnf-plugins-core#549

[pcreech]

ACK!

I'm liking the conditional dependencies!

[evgeni]

Okay, but we gate our publishing on repoclosure (not like some other projects cough), so that means we need the if downstream_build hack to make this work without breaking publishing?

[ekohl]

I actually kind of like the downstream_build approach in that we shouldn't have visible traces of downstream specifics in upstream whenever possible.

Just throwing another thought out there: would using Conflicts: satellite-maintain < 0.0.3 also solve it without breaking repoclosure?

[evgeni]

Just throwing another thought out there: would using Conflicts: satellite-maintain < 0.0.3 also solve it without breaking repoclosure?

I am not sure what DNF would do about that (prefer to upgrade s-m vs keep the old f-m package), but certainly can try?

[evgeni]

update not available:

[root@3429dcb9afa6 /]# dnf install ./rubygem-foreman_maintain-1.8.1-2.el9.noarch.rpm 
Last metadata expiration check: 0:00:14 ago on Fri Oct 25 10:08:37 2024.
Error: 
 Problem: package rubygem-foreman_maintain-1:1.8.1-2.el9.noarch from @commandline conflicts with satellite-maintain < 0.0.3 provided by satellite-maintain-0.0.2-1.el9sat.noarch from @System
  - conflicting requests
  - problem with installed package satellite-maintain-0.0.2-1.el9sat.noarch
(try to add '--allowerasing' to command line to replace conflicting packages or '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

update available:

[root@3429dcb9afa6 /]# dnf update ./rubygem-foreman_maintain-1.8.1-2.el9.noarch.rpm 
Last metadata expiration check: 0:00:13 ago on Fri Oct 25 10:09:28 2024.
Dependencies resolved.
=======================================================================================================================================================================================================================================
 Package                                                  Architecture                           Version                                        Repository                                                                        Size
=======================================================================================================================================================================================================================================
Upgrading:
 rubygem-foreman_maintain                                 noarch                                 1:1.8.1-2.el9                                  @commandline                                                                     148 k
 satellite-maintain                                       noarch                                 0.0.3-1.el9sat                                 brew-task-repo-satellite-maintain-0.0.3-1.el9sat                                 7.5 k

Transaction Summary
=======================================================================================================================================================================================================================================
Upgrade  2 Packages

Total size: 156 k
Total download size: 7.5 k