Add foreman_ygg_migration package #11317
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| Name: foreman_ygg_migration | ||
| Version: 0.0.1 | ||
| Summary: A helper package to ease transition from yggdrasil 0.2.z to 0.4.z | ||
| Release: 1%{?dist} | ||
| License: MIT | ||
|
|
||
| %if 0%{?rhel} >= 8 | ||
| Supplements: yggdrasil >= 0.4.0 | ||
|
There was a problem hiding this comment. People can (and do 😢) disable weak dependencies. This is not a blocker (and there is no better package relationship to fix this), but something we should keep in mind and document somewhere. There was a problem hiding this comment. What exactly should we document and where? There was a problem hiding this comment. We should document that if people have weak dependencies disabled, they should install this package explicitly. As to where, I'm not sure if we already have a procedure or something where this would fit well or we'll need to write a new one There was a problem hiding this comment. Yeah, I am not aware of a good place for this (maybe at least release notes?) |
||
| %endif | ||
| Conflicts: yggdrasil < 0.4.0 | ||
|
|
||
| %description | ||
| A helper package to ease transition from yggdrasil 0.2.z to 0.4.z | ||
|
|
||
| %post | ||
| if systemctl is-enabled yggdrasild >/dev/null 2>/dev/null; then | ||
| grep -Pq '^server' /etc/yggdrasil/config.toml || sed -i 's/broker.*=/server =/' /etc/yggdrasil/config.toml | ||
| grep -Pq '^path-prefix' /etc/yggdrasil/config.toml || echo 'path-prefix = "yggdrasil"' >>/etc/yggdrasil/config.toml | ||
| grep -Pq '^data-host' /etc/yggdrasil/config.toml || echo 'data-host = ""' >>/etc/yggdrasil/config.toml | ||
|
|
||
| if grep -q FOREMAN_YGG_WORKER_WORKDIR /etc/systemd/system/yggdrasild.service.d/* 2>/dev/null; then | ||
| mkdir -p /etc/systemd/system/com.redhat.Yggdrasil1.Worker1.foreman.service.d/ | ||
| cp -r /etc/systemd/system/yggdrasild.service.d/* /etc/systemd/system/com.redhat.Yggdrasil1.Worker1.foreman.service.d/ | ||
|
There was a problem hiding this comment. After this, you may need to run |
||
| systemctl daemon-reload | ||
| fi | ||
|
|
||
| systemctl disable --now yggdrasild | ||
|
There was a problem hiding this comment. Shouldn't the old service get uninstalled and thus removed? There was a problem hiding this comment. From what I've seen, we're missing systemd scriptlets in our yggdrasil spec, so while the old package gets uninstalled and the |
||
| systemctl enable --now yggdrasil | ||
|
There was a problem hiding this comment. It may need to restart There was a problem hiding this comment. That would mean that someone installed new-enough yggdrasil, started it and then installed the migration package, correct? There was a problem hiding this comment. Yes, though I also wonder if that use case would be one to error out on. And you really shouldn't error out on RPM scriptlets. Still not entirely sure what's best here and currently my mind is exploring the various paths a user could take. |
||
| fi | ||
|
|
||
| %files | ||
|
|
||
| %changelog | ||
| * Thu Oct 03 2024 Adam Ruzicka <[email protected]> - 0.0.1-1 | ||
| - Initial packaging | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am debating with myself whether this needs to be an own package, vs a sub-package of
foreman_ygg_worker(smth likeforeman_ygg_worker_migrationor so).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be cleaner, but at the same time it is not a migration of
foreman_ygg_worker